Show "delete branch" button on closed pull requests (#6570) #6601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…been closed (#6570) Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
Codecov Report
@@ Coverage Diff @@
## master #6601 +/- ##
=========================================
Coverage ? 40.78%
=========================================
Files ? 421
Lines ? 57571
Branches ? 0
=========================================
Hits ? 23480
Misses ? 30965
Partials ? 3126
Continue to review full report at Codecov.
|
|
What needs to be done in order to merge this? :) |
|
@saitho need two maintainers' approvals. |
zeripath
approved these changes
Apr 20, 2019
Co-Authored-By: saitho <mario.lubenka@googlemail.com>
…closed_pull_requests
lunny
approved these changes
Apr 20, 2019
…closed_pull_requests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6570
Note that these changes introduce a new behaviour:
Closed pull requests whose pull branch was deleted can't be reopened by the user anymore.