Skip to content

Fix partial reversion of #6657 caused by #6314 #6685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2019
Merged

Fix partial reversion of #6657 caused by #6314 #6685

merged 2 commits into from
Apr 20, 2019

Conversation

zeripath
Copy link
Contributor

#6314 accidentally reverted part of #6657

This PR unreverts this.

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Fix reversion caused by 6314
bfe34b2 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath requested a review from richmahn April 19, 2019 21:10
@zeripath zeripath added type/bug issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change labels Apr 19, 2019
@zeripath zeripath added this to the 1.9.0 milestone Apr 19, 2019
@zeripath zeripath changed the title Fix reversion caused by #6314 Fix partial reversion of #6657 caused by #6314 Apr 19, 2019
@codecov-io
Copy link

codecov-io commented Apr 19, 2019 •
edited
Loading

Codecov Report

Merging #6685 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6685      +/-   ##
==========================================
- Coverage   40.87%   40.86%   -0.01%     
==========================================
  Files         420      420              
  Lines       57454    57453       -1     
==========================================
- Hits        23482    23481       -1     
  Misses      30846    30846              
  Partials     3126     3126
Impacted Files Coverage Δ
routers/repo/editor.go 25.19% <ø> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33f7f7...5b723f3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 19, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 20, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2019
@zeripath zeripath merged commit 6cb127d into go-gitea:master Apr 20, 2019
@zeripath zeripath deleted the fix-reversion-of-6657-by-6314 branch April 20, 2019 07:59
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@richmahn richmahn Awaiting requested review from richmahn

+1 more reviewer

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zeripath @codecov-io @lunny @mrsdizzie @GiteaBot