Skip to content

Conversation

sapk
Copy link
Member

@sapk sapk commented Apr 17, 2019

Based on dependabot reports + vendor.

Fix some bugs like :

  • Fix typo ("PASS" -> "FAIL")

Bumps github.com/stretchr/testify from 1.2.2 to 1.3.0.

Release notes

Sourced from github.com/stretchr/testify's releases.

v1.3.0

Pull requests included in this release:

  • #678 - Fixed incorrect comment
  • #661 - Allow assert.Equal on string type alias without panicking on failure
  • #659 - Add Go1.11 to CI
  • #682 - update comment to match function name
  • #688 - Bump Go versions and use '.x' to always get latest minor versions
  • #648 - Update the LICENSE to match the 'standard' MIT license file
  • #699 - Support arbitrary objects as the sole element in msgAndArgs
  • #696 - Recover panic in suite
  • #655 - Add support for subtests (go 1.7)
  • #607 - Add go.mod and go.modverify
  • #670 - Fix typo ("PASS" -> "FAIL")
  • #712 - Preserve stack frame for mock parent method call
  • #707 - fix for comparing kinds
  • #697 - Update readme to deprecate http and include available packages
Commits
  • ffdc059 Update readme to deprecate http and include available packages
  • 1ecda49 fix for comparing kinds
  • f1df803 Preserve stack frame for mock parent method call
  • 26d4a37 Fix typo ("PASS" -> "FAIL")
  • 865fb2c Add support for subtests (go 1.7)
  • c45a138 Add go.mod and go.sum
  • 660f15d Recover panic in suite
  • 5b93e2d Run go fmt
  • 6697e04 Support arbitrary objects in msgAndArgs
  • 199de5f Update the LICENSE to match the 'standard' MIT license file
  • Additional commits viewable in compare view

@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Apr 17, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Apr 17, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 17, 2019
@codecov-io
Copy link

codecov-io commented Apr 17, 2019

Codecov Report

Merging #6663 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6663      +/-   ##
==========================================
+ Coverage   40.54%   40.55%   +<.01%     
==========================================
  Files         406      406              
  Lines       54501    54501              
==========================================
+ Hits        22097    22101       +4     
+ Misses      29368    29363       -5     
- Partials     3036     3037       +1
Impacted Files Coverage Δ
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f19b08...52c6ddb. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 17, 2019
@techknowlogick techknowlogick merged commit 84fd242 into go-gitea:master Apr 17, 2019
@sapk sapk deleted the update-testify branch April 17, 2019 11:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants