Skip to content

Properly escape on the redirect from the web editor #6657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2019
Merged

Properly escape on the redirect from the web editor #6657

merged 3 commits into from
Apr 17, 2019

Conversation

zeripath
Copy link
Contributor

When creating a new branch with the web editor there is insufficient escaping of the branch name and the treepath. This PR fixes this.

@zeripath zeripath added this to the 1.9.0 milestone Apr 16, 2019
@codecov-io
Copy link

codecov-io commented Apr 16, 2019 •
edited
Loading

Codecov Report

Merging #6657 into master will not change coverage.
The diff coverage is 14.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6657   +/-   ##
=======================================
  Coverage   40.54%   40.54%           
=======================================
  Files         406      406           
  Lines       54501    54501           
=======================================
  Hits        22096    22096           
  Misses      29369    29369           
  Partials     3036     3036
Impacted Files Coverage Δ
routers/repo/editor.go 28.67% <14.28%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867ad49...f1f5a3c. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 16, 2019
@zeripath zeripath mentioned this pull request Apr 16, 2019
Closed
7 tasks
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 16, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 16, 2019
@techknowlogick techknowlogick merged commit 6821a32 into go-gitea:master Apr 17, 2019
@zeripath zeripath deleted the fix-redirect-at-end-create branch April 17, 2019 03:53
zeripath added a commit to zeripath/gitea that referenced this pull request Apr 17, 2019
@zeripath
Properly escape on the redirect from the web editor (go-gitea#6657)
f12acb6
@zeripath zeripath mentioned this pull request Apr 17, 2019
Merged
techknowlogick pushed a commit that referenced this pull request Apr 17, 2019
@zeripath @techknowlogick
Properly escape on the redirect from the web editor (#6657) (#6667)
66a3353
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Apr 17, 2019
@zeripath zeripath mentioned this pull request Apr 19, 2019
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
3 more reviewers

@richmahn richmahn richmahn approved these changes

@sapk sapk sapk approved these changes

@kolaente kolaente kolaente approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
7 participants
@zeripath @codecov-io @richmahn @sapk @kolaente @techknowlogick @GiteaBot