Skip to content

Conversation

zeripath
Copy link
Contributor

The dropdown icon have too much bottom padding. This PR fixes this.

From:
dropdown-too-padded

To:
dropdown-fixed

Signed-off-by: Andrew Thornton art27@cantab.net

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added backport/v1.8 topic/ui Change the appearance of the Gitea UI labels Apr 16, 2019
@zeripath zeripath added this to the 1.9.0 milestone Apr 16, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 16, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #6651 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6651      +/-   ##
==========================================
- Coverage   40.55%   40.54%   -0.01%     
==========================================
  Files         406      406              
  Lines       54501    54501              
==========================================
- Hits        22101    22100       -1     
- Misses      29362    29365       +3     
+ Partials     3038     3036       -2
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
modules/log/log.go 71.42% <0%> (+2.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bce189...d733ec9. Read the comment docs.

@techknowlogick techknowlogick merged commit 8d01b98 into go-gitea:master Apr 16, 2019
@zeripath zeripath deleted the fix-dropdown-icon-padding branch April 16, 2019 16:32
zeripath added a commit to zeripath/gitea that referenced this pull request Apr 16, 2019
Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick pushed a commit that referenced this pull request Apr 16, 2019
Signed-off-by: Andrew Thornton <art27@cantab.net>
@lunny
Copy link
Member

lunny commented Apr 17, 2019

Please send back port to v1.8

@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Apr 17, 2019
@techknowlogick
Copy link
Member

@lunny done.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants