Fix wrong GPG expire date #6643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsdizzie
approved these changes
Apr 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #6643 +/- ##
==========================================
+ Coverage 40.53% 40.54% +<.01%
==========================================
Files 406 406
Lines 54494 54498 +4
==========================================
+ Hits 22088 22094 +6
+ Misses 29370 29368 -2
Partials 3036 3036
Continue to review full report at Codecov.
|
lunny
pushed a commit
that referenced
this pull request
Apr 16, 2019
* fix expire of gpg relative to key creation https://tools.ietf.org/html/rfc4880#section-5.2.3.6 * add test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6599
The expire date of key is calculated relative to creation time of the key not the sig. https://tools.ietf.org/html/rfc4880#section-5.2.3.6