Improve SHA1 link detection #6526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the SHA1 link detection to not pick up extraneous non-whitespace characters at the end of the URL. The '.' is a special case handled in code itself because of missing regexp lookahead support. Regex test cases: https://regex101.com/r/xUMlqh/3
Codecov Report
@@ Coverage Diff @@
## master #6526 +/- ##
==========================================
- Coverage 40.28% 40.26% -0.03%
==========================================
Files 403 403
Lines 54069 54079 +10
==========================================
- Hits 21784 21775 -9
- Misses 29268 29286 +18
- Partials 3017 3018 +1
Continue to review full report at Codecov.
|
|
Just in case anyone is wondering: My motiviation for this change is that I like to post The dot at the end caused the link to become invalid because the old parser appended |
lafriks
approved these changes
Apr 6, 2019
adelowo
approved these changes
Apr 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the SHA1 link detection to not pick up extraneous non-whitespace characters at the end of the URL. The '.' is a special case handled in code itself because of missing regexp lookahead support.
Regex test cases: https://regex101.com/r/xUMlqh/3/
Before
After