Fixes #6514 - New Pull Request on files and pulls pages the same #6515
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6515 +/- ##
==========================================
- Coverage 40.37% 40.35% -0.02%
==========================================
Files 405 405
Lines 54260 54260
==========================================
- Hits 21905 21896 -9
- Misses 29340 29349 +9
Partials 3015 3015
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Ok I think I understand what you're saying - and I think I agree but eurgh PR compare URLs are confusing.
I really think they need a good review of what they should be doing in general. The compare endpoint should also have a UI to easily allow you to change it.
|
@zeripath I agree. When my org wanted this fix, I actually started to try to make the compare page more like GitHubs, where you can pick any fork and any branch of that fork, but alas they just wanted it to simply compare the upstream with whatever fork they were viewing. It would be nice that this behaved like GitHub and I thought everything in Gitea was suppose to be as similar as possible with GitHub. Another problem is that on GitHub, even when you're on your fork, the number of forks of the repo (shown in the top right) should be total forks of upstream and all forks, not just that fork. Anyway, just a quick fix to make it so the user doesn't have to edit the compare URL themselves as you figured out. |
|
@adelowo what do you think? |
Makes "New Pull Request" button on a Repo's Pull Requests page have the correct link as the "New Pull Request" button on the repo's home page (file listing) has. See #6514 for more details.