Skip to content

Properly escape release attachment URL #6512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2019
Merged

Properly escape release attachment URL #6512

merged 2 commits into from
Apr 5, 2019

Conversation

mrsdizzie
Copy link
Member

Make sure file attachments on a release get a properly escaped URL when
linking.

Fixes #6506

@mrsdizzie
Properly escape release attachment URL
d05dbf7 
Make sure file attachments on a release get a properly escaped URL when
linking.

Fixes go-gitea#6506
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 5, 2019
@zeripath zeripath added this to the 1.9.0 milestone Apr 5, 2019
@zeripath zeripath added backport/done All backports for this PR have been created backport/v1.8 type/bug and removed backport/done All backports for this PR have been created labels Apr 5, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #6512 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6512      +/-   ##
==========================================
+ Coverage   40.26%   40.26%   +<.01%     
==========================================
  Files         403      403              
  Lines       54069    54069              
==========================================
+ Hits        21770    21772       +2     
+ Misses      29282    29280       -2     
  Partials     3017     3017
Impacted Files Coverage Δ
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bf20f4...7ee1c71. Read the comment docs.

@techknowlogick techknowlogick merged commit 0bdd81d into go-gitea:master Apr 5, 2019
@techknowlogick
Copy link
Member

@mrsdizzie merged. Please backport :)

mrsdizzie added a commit to mrsdizzie/gitea that referenced this pull request Apr 5, 2019
@mrsdizzie
Properly escape release attachment URL (go-gitea#6512)
307ff96 
Make sure file attachments on a release get a properly escaped URL when
linking.

Fixes go-gitea#6506
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Apr 5, 2019
techknowlogick pushed a commit that referenced this pull request Apr 5, 2019
@mrsdizzie @techknowlogick
Properly escape release attachment URL (#6512) (#6523)
2551660 
Make sure file attachments on a release get a properly escaped URL when
linking.

Fixes #6506
6543 added a commit to 6543-forks/gitea that referenced this pull request Dec 28, 2019
@6543
handle if two or more attachement have same name
999c8d8 
* before only first got downloaded - now each is downloadable
* dos also take care of  go-gitea#6506 (fix was: go-gitea#6512)
zeripath pushed a commit that referenced this pull request Dec 28, 2019
@6543 @zeripath
[Fix] Release attachment should use Downloadurl("") not Name (#9529)
261c3a5 
* Handle if two or more attachments have the same name
* previously only the first could be downloaded - now each is downloadable
* dos also take care of  #6506 (fix was: #6512)
* use func Downloadurl("") at issue attatchments too
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

attachments download url not encode
6 participants
@mrsdizzie @codecov-io @techknowlogick @lafriks @zeripath @GiteaBot