Skip to content

Remove the local clones #6505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 25 commits into from
Closed

Remove the local clones #6505

wants to merge 25 commits into from

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Apr 3, 2019 •
edited
Loading

In several places Gitea still makes full local clones instead of using a shared repository.

This PR aims to remove these - using bare copies where it can.

@zeripath zeripath force-pushed the fix-6490-remove-the-clones branch from 68fdbd0 to fbaee15 Compare April 4, 2019 21:55
@codecov-io
Copy link

codecov-io commented Apr 4, 2019 •
edited
Loading

Codecov Report

Merging #6505 into master will decrease coverage by <.01%.
The diff coverage is 59.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6505      +/-   ##
==========================================
- Coverage   40.54%   40.53%   -0.01%     
==========================================
  Files         406      410       +4     
  Lines       54501    54504       +3     
==========================================
- Hits        22095    22091       -4     
+ Misses      29370    29369       -1     
- Partials     3036     3044       +8
Impacted Files Coverage Δ
models/user.go 50.18% <ø> (-0.14%) ⬇️
modules/setting/repository.go 51.42% <ø> (ø) ⬆️
routers/repo/branch.go 58.19% <ø> (+1.28%) ⬆️
modules/git/repo.go 61.14% <100%> (-6.41%) ⬇️
models/repo.go 46.78% <100%> (-0.17%) ⬇️
modules/git/tree_entry.go 74.25% <100%> (+0.52%) ⬆️
modules/git/repo_branch.go 75% <100%> (ø) ⬆️
models/repo_branch.go 54.61% <39.58%> (-0.36%) ⬇️
models/wiki.go 58.87% <49.24%> (-3.63%) ⬇️
modules/uploader/repo.go 50% <51.02%> (-17.05%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d01b98...511da8a. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 4, 2019
@zeripath
Copy link
Contributor Author

zeripath commented Apr 4, 2019 •
edited
Loading

Unfortunately it's still the case that setting SSH_ORIGINAL_COMMAND causes the tests to fail as the hooks don't seem to work when running on the testcases.

@zeripath zeripath changed the title WIP: Remove the local clones Remove the local clones Apr 6, 2019
@zeripath zeripath added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 6, 2019
@zeripath zeripath added this to the 1.9.0 milestone Apr 6, 2019
@zeripath zeripath mentioned this pull request Apr 6, 2019
Merged
@zeripath
Copy link
Contributor Author

zeripath commented Apr 6, 2019

I've now enabled SSH_ORIGINAL_COMMAND wherever we internally push.

lunny
lunny reviewed Apr 8, 2019
View reviewed changes
lunny
lunny requested changes Apr 8, 2019
View reviewed changes
@zeripath zeripath mentioned this pull request Apr 8, 2019
Closed
@lunny lunny added the type/bug label Apr 9, 2019
@lunny
Copy link
Member

lunny commented Apr 9, 2019

Will fix #6544

@zeripath zeripath mentioned this pull request Apr 11, 2019
Merged
@zeripath
Copy link
Contributor Author

This severely conflicts with #6314 in ways that will require more thought. It also likely severely conflicts with @filipnavara 's #6478 . I'm therefore going to close this.

@zeripath zeripath closed this Apr 17, 2019
@filipnavara
Copy link
Contributor

filipnavara commented Apr 17, 2019 •
edited
Loading

I think it deserves to be revisited but at the moment I already spent hours to resolve conflicts on my PR so I'm too tired to look into doing it here too.

@zeripath
Copy link
Contributor Author

Aha! the issue is that #6314 can't cope with the hooks being run!

@zeripath zeripath mentioned this pull request Apr 18, 2019
Merged
@zeripath zeripath deleted the fix-6490-remove-the-clones branch October 16, 2019 15:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny requested changes

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zeripath @codecov-io @lunny @filipnavara @GiteaBot