Skip to content

[docker] drop the bits argument when generating an ed25519 key #6504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2019
Merged

[docker] drop the bits argument when generating an ed25519 key #6504

merged 1 commit into from
Apr 4, 2019

Conversation

das7pad
Copy link
Contributor

@das7pad das7pad commented Apr 3, 2019

From the man page of ssh-keygen [1]:

Ed25519 keys have a fixed length and the -b flag will be ignored.

The actual private key size for Ed25519 is 256 bits [1] which does not match with the currently specified 4096 bits anyways.

[1] https://man.openbsd.org/ssh-keygen#b
[2] https://tools.ietf.org/html/rfc8032#section-5.1.5

@das7pad
[docker] drop the bits argument when generating an ed25519 key
733fb95 
From the man page of ssh-keygen:

  Ed25519 keys have a fixed length and the -b flag will be ignored.

[skip ci]

Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
@codecov-io
Copy link

Codecov Report

Merging #6504 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6504      +/-   ##
==========================================
- Coverage   40.27%   40.27%   -0.01%     
==========================================
  Files         403      403              
  Lines       54068    54068              
==========================================
- Hits        21775    21774       -1     
- Misses      29276    29277       +1     
  Partials     3017     3017
Impacted Files Coverage Δ
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5af87...733fb95. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 3, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 3, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 4, 2019
@lafriks lafriks added this to the 1.9.0 milestone Apr 4, 2019
@lafriks lafriks merged commit 3f4e2d9 into go-gitea:master Apr 4, 2019
@das7pad das7pad deleted the misc/drop-ed25519-bits branch April 4, 2019 07:10
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/miscellaneous
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@das7pad @codecov-io @lafriks @sapk @GiteaBot