Skip to content

Conversation

jonasfranz
Copy link
Member

Disables refresh token invalidation by default (as option) to fix concurrency problems with drone.

Blocks harness/harness#2622

jonasfranz and others added 4 commits April 11, 2019 21:01
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Signed-off-by: Jonas Franz <info@jonasfranz.software>
@codecov-io
Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #6584 into master will increase coverage by 0.03%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6584      +/-   ##
=========================================
+ Coverage   40.46%   40.5%   +0.03%     
=========================================
  Files         405     405              
  Lines       54350   54351       +1     
=========================================
+ Hits        21994   22013      +19     
+ Misses      29332   29311      -21     
- Partials     3024    3027       +3
Impacted Files Coverage Δ
modules/auth/user_form.go 42.85% <ø> (ø) ⬆️
modules/setting/setting.go 48.16% <ø> (ø) ⬆️
routers/user/oauth.go 44% <28.57%> (+5.11%) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️
models/oauth2_application.go 56.04% <0%> (+1.2%) ⬆️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff0a12...7b6dc70. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 12, 2019
@jonasfranz jonasfranz marked this pull request as ready for review April 12, 2019 06:49
@jonasfranz jonasfranz changed the title WIP: Add option to disable refresh token invalidation Add option to disable refresh token invalidation Apr 12, 2019
@jonasfranz jonasfranz added this to the 1.8.0 milestone Apr 12, 2019
@jonasfranz jonasfranz added the type/enhancement An improvement of existing functionality label Apr 12, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 12, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 12, 2019
@lunny lunny merged commit 783cd64 into go-gitea:master Apr 12, 2019
@jonasfranz jonasfranz deleted the feature/disable-refresh-token-invalidation branch April 12, 2019 08:25
@lunny
Copy link
Member

lunny commented Apr 12, 2019

@jonasfranz please send a back port to release/v1.8

@lunny lunny modified the milestones: 1.8.0, 1.9.0 Apr 12, 2019
jonasfranz added a commit to jonasfranz/gitea that referenced this pull request Apr 12, 2019
* Add option to disable refresh token invalidation

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add integration tests and remove wrong todos

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Fix typo

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Fix tests and add documentation

Signed-off-by: Jonas Franz <info@jonasfranz.software>

(cherry picked from commit 783cd64)
Signed-off-by: Jonas Franz <info@jonasfranz.software>
@jonasfranz
Copy link
Member Author

@lunny Backport done: #6587

lafriks pushed a commit that referenced this pull request Apr 12, 2019
* Add option to disable refresh token invalidation

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add integration tests and remove wrong todos

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Fix typo

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Fix tests and add documentation

Signed-off-by: Jonas Franz <info@jonasfranz.software>

(cherry picked from commit 783cd64)
Signed-off-by: Jonas Franz <info@jonasfranz.software>
@jonasfranz jonasfranz added backport/done All backports for this PR have been created backport/v1.8 labels Apr 12, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants