Skip to content

Fix new repo dropdown alignment #6583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2019
Merged

Fix new repo dropdown alignment #6583

merged 2 commits into from
Apr 11, 2019

Conversation

jolheiser
Copy link
Member

@jolheiser jolheiser commented Apr 11, 2019 •
edited
Loading

The alignment for the new repo dropdown was bugging me, so I played with it for a bit and this was the simplest fix I could find.

Before
new_repo_before
After
new_repo_after

@jolheiser
Fix new repo alignment
faf9230 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 11, 2019
@codecov-io
Copy link

codecov-io commented Apr 11, 2019 •
edited
Loading

Codecov Report

Merging #6583 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6583      +/-   ##
==========================================
- Coverage   40.37%   40.35%   -0.02%     
==========================================
  Files         405      405              
  Lines       54260    54260              
==========================================
- Hits        21907    21898       -9     
- Misses      29337    29347      +10     
+ Partials     3016     3015       -1
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad65bb...17bf579. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 11, 2019
@jolheiser
Resolve conflicts
17bf579 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@zeripath zeripath merged commit 48cdd90 into go-gitea:master Apr 11, 2019
@zeripath zeripath added this to the 1.9.0 milestone Apr 11, 2019
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Apr 11, 2019
@zeripath
Copy link
Contributor

Please backport to 1.8

@jolheiser jolheiser deleted the fix_repo_dropdown branch April 11, 2019 21:20
jolheiser added a commit to jolheiser/gitea that referenced this pull request Apr 11, 2019
@jolheiser
Fix new repo alignment (go-gitea#6583)
d22e486 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@zeripath zeripath added the backport/done All backports for this PR have been created label Apr 11, 2019
techknowlogick pushed a commit that referenced this pull request Apr 11, 2019
@jolheiser @techknowlogick
Fix new repo alignment (#6583) (#6585)
95e12be 
* Fix new repo alignment (#6583)

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Kick Drone

* Make stylesheets again.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jolheiser @codecov-io @zeripath @adelowo @GiteaBot