Skip to content

fix mail notification when close/reopen issue #6581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2019
Merged

fix mail notification when close/reopen issue #6581

merged 3 commits into from
Apr 11, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 11, 2019

will fix #6580

@lunny lunny added the type/enhancement An improvement of existing functionality label Apr 11, 2019
@codecov-io
Copy link

codecov-io commented Apr 11, 2019 •
edited
Loading

Codecov Report

Merging #6581 into master will increase coverage by 0.01%.
The diff coverage is 42.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6581      +/-   ##
==========================================
+ Coverage   40.35%   40.36%   +0.01%     
==========================================
  Files         405      405              
  Lines       54260    54279      +19     
==========================================
+ Hits        21896    21911      +15     
- Misses      29349    29351       +2     
- Partials     3015     3017       +2
Impacted Files Coverage Δ
modules/notification/mail/mail.go 22.64% <25%> (+2.64%) ⬆️
models/issue_mail.go 54.76% <70%> (+0.91%) ⬆️
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48cdd90...6149ac0. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 11, 2019
zeripath
zeripath approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to internationalise these emails in general.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 11, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 11, 2019
@zeripath zeripath added this to the 1.9.0 milestone Apr 11, 2019
@zeripath zeripath merged commit 2f53b5f into go-gitea:master Apr 11, 2019
@lunny lunny deleted the lunny/fix_mail_action branch April 12, 2019 01:07
@zeripath zeripath mentioned this pull request Apr 12, 2019
Closed
7 tasks
@femaref
Copy link

femaref commented Apr 12, 2019

I think this should be backported, as it's a small, but highly impactful quality of life fix. we are working in a larger team, as such the throughput can be quite high. right now, I have to open every email to see if the ticket was closed or if it's a new ticket/comment. this is quite annoying and having to tell my team it will take some time until this stops isn't something I'm looking forward to.

@zeripath
Copy link
Contributor

Seems reasonable to me that this could be backported. @lunny can we send a backport?

lunny added a commit to lunny/gitea that referenced this pull request Apr 12, 2019
@lunny
fix mail notification when close/reopen issue (go-gitea#6581)
72ccb2a
@lunny lunny mentioned this pull request Apr 12, 2019
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Apr 12, 2019
@lunny
Copy link
Member Author

lunny commented Apr 12, 2019

@zeripath done.

zeripath pushed a commit that referenced this pull request Apr 12, 2019
@lunny @zeripath
fix mail notification when close/reopen issue (#6581) (#6588)
4b87aa3
@zeripath
Copy link
Contributor

@femaref The backport is in our release/v1.8 branch now.

@femaref
Copy link

femaref commented Apr 12, 2019

thank you. are there builds available before they are released as rc? or do I have to build it myself?

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Close/Reopen issue sends notification with the text of the issue
6 participants
@lunny @codecov-io @femaref @zeripath @adelowo @GiteaBot