Skip to content

fix bug user search API pagesize didn't obey ExplorePagingNum #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2019
Merged

fix bug user search API pagesize didn't obey ExplorePagingNum #6579

merged 3 commits into from
Apr 11, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 11, 2019

Will fix #3731. This PR will remove the wrong default limit code on route since the SearchUsers have the codes.

@lunny lunny added the type/bug label Apr 11, 2019
@lunny lunny mentioned this pull request Apr 11, 2019
Closed
7 tasks
@codecov-io
Copy link

codecov-io commented Apr 11, 2019 •
edited
Loading

Codecov Report

Merging #6579 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6579      +/-   ##
==========================================
+ Coverage   40.35%   40.37%   +0.01%     
==========================================
  Files         405      405              
  Lines       54279    54277       -2     
==========================================
+ Hits        21906    21913       +7     
+ Misses      29356    29346      -10     
- Partials     3017     3018       +1
Impacted Files Coverage Δ
routers/api/v1/user/user.go 23.7% <ø> (+0.34%) ⬆️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f53b5f...7c0dee9. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 11, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 11, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 11, 2019
@zeripath zeripath added this to the 1.9.0 milestone Apr 11, 2019
@techknowlogick techknowlogick merged commit 1b7dffc into go-gitea:master Apr 11, 2019
@techknowlogick
Copy link
Member

@lunny merged. Please backport 😃

@lunny lunny mentioned this pull request Apr 12, 2019
Merged
@lunny lunny deleted the lunny/fix_defulat_limit branch April 12, 2019 01:13
@lunny lunny added the backport/done All backports for this PR have been created label Apr 12, 2019
@lunny
Copy link
Member Author

lunny commented Apr 12, 2019

@techknowlogick back port done.

lunny added a commit to lunny/gitea that referenced this pull request Apr 12, 2019
@lunny
fix bug user search API pagesize didn't obey ExplorePagingNum (go-git…
e4a9741 
…ea#6579)
techknowlogick pushed a commit that referenced this pull request Apr 12, 2019
@lunny @techknowlogick
fix bug user search API pagesize didn't obey ExplorePagingNum (#6579) (…
5be1b7d 
…#6586)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

users/search API results appear to be incorrectly limited by ui/EXPLORE_PAGING_NUM value
6 participants
@lunny @codecov-io @techknowlogick @zeripath @adelowo @GiteaBot