Skip to content

Render SHA1 links as code blocks #6546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2019
Merged

Render SHA1 links as code blocks #6546

merged 1 commit into from
Apr 9, 2019

Conversation

silverwind
Copy link
Member

This changes the rendering of SHA1 hashes to render with <code> blocks, matching GitHub's behaviour. I added a new createCodeLink function and simplified createLink a bit.

Before

Screenshot 2019-04-08 at 21 27 17

After

Screenshot 2019-04-08 at 21 27 25

@codecov-io
Copy link

Codecov Report

Merging #6546 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6546      +/-   ##
==========================================
+ Coverage   40.34%   40.35%   +0.01%     
==========================================
  Files         405      405              
  Lines       54236    54251      +15     
==========================================
+ Hits        21879    21895      +16     
+ Misses      29341    29340       -1     
  Partials     3016     3016
Impacted Files Coverage Δ
modules/markup/html.go 82.91% <100%> (+0.55%) ⬆️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b8599...5e4f32b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 8, 2019
zeripath
zeripath approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @silverwind your UI work is appreciated greatly

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 8, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 8, 2019
@lafriks lafriks merged commit 8e949db into go-gitea:master Apr 9, 2019
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Apr 9, 2019
@lafriks lafriks modified the milestones: 1.x.x, 1.7.6, 1.9.0 Apr 9, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @codecov-io @zeripath @adelowo @lafriks @GiteaBot