Skip to content

Fixed unitTypeCode not being used in accessLevelUnit #6419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2019
Merged

Fixed unitTypeCode not being used in accessLevelUnit #6419

merged 1 commit into from
Mar 24, 2019

Conversation

kolaente
Copy link
Member

While doing some refactoring for #6418 I discovered this function was essentially useless.

@lunny
Copy link
Member

lunny commented Mar 24, 2019

@kolaente also find HasAccessUnit is not used any more. Maybe we could remove it.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 24, 2019
@lunny lunny added the type/bug label Mar 24, 2019
@lunny
Copy link
Member

lunny commented Mar 24, 2019

Since canBeAssigned referenced hasAccessUnit and it in fact gave unitType as UnitTypeCode. This haven't really taken an effect.

@lunny lunny added this to the 1.9.0 milestone Mar 24, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@b48be19). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6419   +/-   ##
=========================================
  Coverage          ?   38.87%           
=========================================
  Files             ?      365           
  Lines             ?    51393           
  Branches          ?        0           
=========================================
  Hits              ?    19979           
  Misses            ?    28547           
  Partials          ?     2867
Impacted Files Coverage Δ
models/repo_permission.go 72.02% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48be19...ac09e74. Read the comment docs.

@kolaente
Copy link
Member Author

Since canBeAssigned referenced hasAccessUnit and it in fact gave unitType as UnitTypeCode. This haven't really taken an effect.

Sure, but I'd do that in #6418 as there are a lot other unused functions as well which I removed in that pr also.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 24, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 24, 2019
@lafriks lafriks merged commit fb2ea06 into go-gitea:master Mar 24, 2019
@kolaente
Copy link
Member Author

Should I send a backport?

@lafriks
Copy link
Member

lafriks commented Mar 24, 2019

I think yes

zeripath pushed a commit that referenced this pull request Mar 24, 2019
@kolaente @zeripath
Fixed unitTypeCode not being used (#6419) (#6422)
93e8174
@lafriks lafriks added backport/v1.7 backport/done All backports for this PR have been created labels Mar 24, 2019
@kolaente kolaente deleted the fix/access-level-unit branch March 24, 2019 20:24
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@kolaente @lunny @codecov-io @lafriks @zeripath @GiteaBot