Support search operators for commits search #6479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6479 +/- ##
==========================================
+ Coverage 40.35% 40.48% +0.12%
==========================================
Files 405 405
Lines 54277 54320 +43
==========================================
+ Hits 21904 21989 +85
+ Misses 29356 29312 -44
- Partials 3017 3019 +2
Continue to review full report at Codecov.
|
|
@typeless could you add some tests? |
3059b38 to
b346859
Compare
|
The test does not work yet. |
a722086 to
a354319
Compare
|
Added some basic tests. |
b15121a to
d8e9be0
Compare
|
All tests passed. It is ready for review. |
zeripath
approved these changes
Apr 6, 2019
zeripath
approved these changes
Apr 7, 2019
For now, support auther: committer: When more than one prefix is supplied is presented, the result is the union. When different prefixes are supplied, the result is the intersection. For example, "author:alice author:bob" => the result is all commits authored by Alice OR Bob "hello committer:alice" => the result is all commits committed by Alice AND has the keyword 'hello' in the message. Note that there should NOT have any space after the colon(:) of the prefix. For example, "author:bill" => correct "author: bill" => wrong
I have no idea about how to format it with line breaks.
e64e61d to
c8753e1
Compare
|
Hold on, I accidentally |
|
Fixed. |
mrsdizzie
suggested changes
Apr 10, 2019
mrsdizzie
approved these changes
Apr 11, 2019
sapk
approved these changes
Apr 11, 2019
lunny
reviewed
Apr 11, 2019
|
@typeless thanks for your PR. My comment is not a block that could be another PR. |
|
@lunny okay, thanks. |
lunny
approved these changes
Apr 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, support auther:, committer:, after: and before:,
When more than one prefix is supplied, the result is the union.
When different prefixes are supplied, the result is the intersection.
For example,
"author:alice author:bob"
=> the result is all commits authored by Alice OR Bob
"hello committer:alice after:2019-03-05 before:2019-03-10"
=> the result is all commits committed by Alice AND has the keyword during 2019-03-05~2019-03-10.
'hello' in the message.
Essentially, this is a wrapper for
git logwith the support of--grep,--author,--committer,--after, and--beforeoptions.Note that there should NOT have any space after the colon(:) of the prefix.
For example,
"author:bill" => correct
"author: bill" => wrong