Fix repo sub_menu font color in arc-green #6477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6477 +/- ##
==========================================
+ Coverage 39.39% 39.39% +<.01%
==========================================
Files 393 393
Lines 53271 53271
==========================================
+ Hits 20986 20988 +2
+ Misses 29299 29297 -2
Partials 2986 2986
Continue to review full report at Codecov.
|
kolaente
approved these changes
Apr 1, 2019
adelowo
approved these changes
Apr 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Discord, this PR fixes the coloring of the active tab in a repo.
Before
After
As for actual changes, I opted to add the
uiclass to the link, which breaks it from the CSS that styled it black beforehand. Perhaps an explicit override inarc-green.csswould also make sense, but this seemed to be the simplest fix without altering existing styles.