Fix #6468 - Uses space match and adds newline for all sed flavors #6473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6473 +/- ##
==========================================
- Coverage 39.4% 39.39% -0.01%
==========================================
Files 393 393
Lines 53271 53271
==========================================
- Hits 20992 20988 -4
- Misses 29292 29297 +5
+ Partials 2987 2986 -1
Continue to review full report at Codecov.
|
zeripath
approved these changes
Mar 30, 2019
adelowo
approved these changes
Mar 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: #6468
This makes it so both GNU sed (Linux) and FreeBSD sed (MacOS) can be used for the sed commands used after the swagger command in
make generate-swagger.FreeBSD sed does not support \s so just a space is used now between basePath: and "/api/v1" as that all there will be.
For the new line at end of file, FreeBSD feels it should always add it, GNU sed does not. Easiest to add the
-e '$a\'command which adds a new line at the end of a file if one doesn't already exist.Before one could use homebrew to install GNU sed and rename gsed to sed, but now one can't. Also aliasing gsed to sed was not possible.