Skip to content

fix: avoid multi-clicks in oauth2 login #6467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2019
Merged

fix: avoid multi-clicks in oauth2 login #6467

merged 2 commits into from
Mar 31, 2019

Conversation

BetaCat0
Copy link
Member

Simply fix in frontend, ref issue: #6268

@lunny lunny added the type/bug label Mar 29, 2019
@BetaCat0 BetaCat0 changed the title fix: avoid multi-clicks when perform oauth2 login fix: avoid multi-clicks in oauth2 login Mar 29, 2019
@BetaCat0 BetaCat0 force-pushed the avoid-multi-clicks-with-oauth2-login branch from d4a8a21 to a7192ee Compare March 29, 2019 15:29
@BetaCat0 BetaCat0 force-pushed the avoid-multi-clicks-with-oauth2-login branch from a7192ee to e02543b Compare March 29, 2019 15:33
@codecov-io
Copy link

codecov-io commented Mar 29, 2019 •
edited
Loading

Codecov Report

Merging #6467 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6467      +/-   ##
==========================================
- Coverage    39.4%   39.39%   -0.01%     
==========================================
  Files         393      393              
  Lines       53271    53271              
==========================================
- Hits        20992    20988       -4     
- Misses      29292    29297       +5     
+ Partials     2987     2986       -1
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04d78b6...d5c92cf. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 29, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 30, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 30, 2019
@lunny lunny added this to the 1.9.0 milestone Mar 31, 2019
@lunny lunny merged commit 2e1ead8 into go-gitea:master Mar 31, 2019
@lunny
Copy link
Member

lunny commented Mar 31, 2019

Please send back port to release/v1.8

@lunny lunny mentioned this pull request Apr 14, 2019
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@BetaCat0 @codecov-io @lunny @zeripath @adelowo @GiteaBot