Skip to content

fix bug manifest.json will not request with cookie so that session will created every request #6372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2019
Merged

fix bug manifest.json will not request with cookie so that session will created every request #6372

merged 1 commit into from
Mar 19, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 19, 2019

@lunny lunny added this to the 1.9.0 milestone Mar 19, 2019
@lunny lunny mentioned this pull request Mar 19, 2019
Closed
7 tasks
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f7f2f12). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6372   +/-   ##
=========================================
  Coverage          ?   38.87%           
=========================================
  Files             ?      365           
  Lines             ?    51341           
  Branches          ?        0           
=========================================
  Hits              ?    19957           
  Misses            ?    28511           
  Partials          ?     2873

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7f2f12...767a7c3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 19, 2019
@lunny
Copy link
Member Author

lunny commented Mar 19, 2019

@FloThinksPi My first idea is same as you to disable session on public resources. But I found I'm not familiar with macaron enough to do that in a short time and I think I will send another PR to do that.

@FloThinksPi
Copy link

Yea this will do it as quick fix 👍

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 19, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2019
@techknowlogick techknowlogick merged commit ce646fd into go-gitea:master Mar 19, 2019
@techknowlogick
Copy link
Member

@lunny please create backport PRs

@lunny
Copy link
Member Author

lunny commented Mar 20, 2019

@FloThinksPi Yes, please. And I think maybe some other resources routes should also disable session.

lunny added a commit to lunny/gitea that referenced this pull request Mar 20, 2019
@lunny
fix bug manifest.json will not request with cookie so that session wi…
84c4f42 
…ll created every request (go-gitea#6372)
@lunny lunny mentioned this pull request Mar 20, 2019
Merged
lunny added a commit to lunny/gitea that referenced this pull request Mar 20, 2019
@lunny
fix bug manifest.json will not request with cookie so that session wi…
7a4da9a 
…ll created every request (go-gitea#6372)
@lunny lunny mentioned this pull request Mar 20, 2019
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Mar 20, 2019
@lunny lunny deleted the lunny/fix_manifest_json branch March 20, 2019 01:03
techknowlogick pushed a commit that referenced this pull request Mar 20, 2019
@lunny @techknowlogick
fix bug manifest.json will not request with cookie so that session wi…
00619a0 
…ll created every request (#6372) (#6382)
techknowlogick pushed a commit that referenced this pull request Mar 20, 2019
@lunny @techknowlogick
fix bug manifest.json will not request with cookie so that session wi…
acb9ae4 
…ll created every request (#6372) (#6383)
@FloThinksPi
Copy link

Deleted my comments cause i will send it to security@gitea just to be sure.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

+2 more reviewers

@FloThinksPi FloThinksPi FloThinksPi approved these changes

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

"data/sessions" folder growed up and used 100% inodes
7 participants
@lunny @codecov-io @FloThinksPi @techknowlogick @adelowo @jolheiser @GiteaBot