Skip to content

Disable benchmarking during tag events on DroneIO (#6365) #6366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2019
Merged

Disable benchmarking during tag events on DroneIO (#6365) #6366

merged 1 commit into from
Mar 19, 2019

Conversation

techknowlogick
Copy link
Member

As title

@techknowlogick techknowlogick added this to the 1.8.0 milestone Mar 19, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 19, 2019
zeripath
zeripath approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this is a temporary measure? If not we should just remove these lines instead of commenting them out.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2019
@techknowlogick
Copy link
Member Author

@zeripath yes, temporary. It seems it hangs, and I'd like to look into why this is happening without it holding up the 1.8.0 release. Thanks for LG-TM 😄

@techknowlogick techknowlogick merged commit 3934d9c into release/v1.8 Mar 19, 2019
@techknowlogick techknowlogick deleted the techknowlogick-patch-1 branch March 19, 2019 06:54
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@techknowlogick @lunny @zeripath @GiteaBot