Disable benchmarking during tag events on DroneIO #6365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
approved these changes
Mar 19, 2019
zeripath
approved these changes
Mar 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #6365 +/- ##
==========================================
+ Coverage 38.86% 38.87% +0.01%
==========================================
Files 365 365
Lines 51341 51341
==========================================
+ Hits 19953 19960 +7
+ Misses 28516 28510 -6
+ Partials 2872 2871 -1
Continue to review full report at Codecov.
|
techknowlogick
added a commit
that referenced
this pull request
Mar 19, 2019
techknowlogick
added a commit
that referenced
this pull request
Mar 19, 2019
|
@techknowlogick why ? does it failed during CI ? Because the goal was mainly to keep track of performance between releases. |
|
@sapk yes, it fails on the migrate benchmark. I think we should wait until we migrate to Drone 1.0.0 to resolve this so we can have a separate benchmark pipeline and have that run on a dedicated machine as well. |
|
Create an issue for that is better so that we will not forget that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, will need to be backported to release/v1.8
(When this gets backported 1.8.0-rc1 can be retagged)