Skip to content

update git vendor to fix wrong release commit id and add migrations #6224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 11, 2019
Merged

update git vendor to fix wrong release commit id and add migrations #6224

merged 7 commits into from
Mar 11, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 2, 2019

Should fix #5585

@lunny lunny added the type/bug label Mar 2, 2019
@lunny lunny added this to the 1.8.0 milestone Mar 2, 2019
lafriks
lafriks requested changes Mar 2, 2019
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 2, 2019
techknowlogick
techknowlogick reviewed Mar 9, 2019
View reviewed changes
@lunny lunny force-pushed the lunny/fix_release_tag branch from 203689a to 1f57667 Compare March 9, 2019 15:27
@codecov-io
Copy link

codecov-io commented Mar 9, 2019 •
edited
Loading

Codecov Report

Merging #6224 into master will decrease coverage by 0.05%.
The diff coverage is 6.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6224      +/-   ##
==========================================
- Coverage   38.87%   38.82%   -0.06%     
==========================================
  Files         358      359       +1     
  Lines       51038    51100      +62     
==========================================
- Hits        19842    19839       -3     
- Misses      28324    28391      +67     
+ Partials     2872     2870       -2
Impacted Files Coverage Δ
models/migrations/migrations.go 1.52% <ø> (ø) ⬆️
models/migrations/v82.go 0% <0%> (ø)
models/repo_branch.go 58.27% <100%> (ø) ⬆️
routers/repo/view.go 41.08% <100%> (-1%) ⬇️
models/unit.go 0% <0%> (-14.29%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2315019...6dcf98b. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 9, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 9, 2019
@lunny lunny merged commit 4334fe7 into go-gitea:master Mar 11, 2019
@lunny lunny mentioned this pull request Mar 11, 2019
Merged
@lunny lunny added backport/done All backports for this PR have been created backport/v1.7 labels Mar 11, 2019
@lunny lunny deleted the lunny/fix_release_tag branch March 11, 2019 04:00
@lunny lunny mentioned this pull request Mar 11, 2019
Merged
lunny added a commit to lunny/gitea that referenced this pull request Mar 12, 2019
@lunny
update git vendor to fix wrong release commit id and add migrations (g…
6f04788 
…o-gitea#6224)

* update git vendor to fix wrong release commit id and add migrations

* fix count

* fix migration release

* fix tests
techknowlogick pushed a commit that referenced this pull request Mar 12, 2019
@lunny @techknowlogick
update git vendor to fix wrong release commit id and add migrations （#…
d0bbfd8 
…6224） (#6300)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Wrong commit Id after creating a release on existing tag
6 participants
@lunny @codecov-io @techknowlogick @lafriks @zeripath @GiteaBot