Skip to content

Issue indexer queue redis support #6218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 8, 2019
Merged

Issue indexer queue redis support #6218

merged 8 commits into from
Apr 8, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 1, 2019

This PR add a redis queue for issue indexer queue.

@lunny lunny added the type/enhancement An improvement of existing functionality label Mar 1, 2019
@lunny lunny added this to the 1.9.0 milestone Mar 1, 2019
@codecov-io
Copy link

codecov-io commented Mar 1, 2019 •
edited
Loading

Codecov Report

Merging #6218 into master will decrease coverage by 0.08%.
The diff coverage is 10.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6218      +/-   ##
==========================================
- Coverage   40.41%   40.33%   -0.09%     
==========================================
  Files         404      405       +1     
  Lines       54140    54236      +96     
==========================================
- Hits        21883    21875       -8     
- Misses      29241    29345     +104     
  Partials     3016     3016
Impacted Files Coverage Δ
modules/indexer/issues/queue_redis.go 0% <0%> (ø)
modules/setting/indexer.go 100% <100%> (ø) ⬆️
modules/indexer/issues/indexer.go 60.5% <36.84%> (-4.96%) ⬇️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e4af49...1af665e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 1, 2019
adelowo
adelowo reviewed Mar 1, 2019
View reviewed changes
@lunny lunny force-pushed the lunny/issue_indexer_redis branch from 81903c3 to ac2b547 Compare April 2, 2019 02:04
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 7, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 8, 2019
@lafriks lafriks merged commit e7d7dcb into go-gitea:master Apr 8, 2019
@lunny lunny deleted the lunny/issue_indexer_redis branch November 18, 2020 04:33
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+2 more reviewers

@adelowo adelowo adelowo left review comments

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-io @lafriks @zeripath @adelowo @GiteaBot