Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 28, 2019

Before this PR, when a user was asked to change his password, he will still view dashboard.

@lunny lunny added this to the 1.8.0 milestone Feb 28, 2019
@codecov-io
Copy link

codecov-io commented Feb 28, 2019

Codecov Report

Merging #6214 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6214      +/-   ##
==========================================
- Coverage   38.86%   38.86%   -0.01%     
==========================================
  Files         354      354              
  Lines       50204    50210       +6     
==========================================
- Hits        19513    19512       -1     
- Misses      27867    27872       +5     
- Partials     2824     2826       +2
Impacted Files Coverage Δ
modules/context/auth.go 18.84% <0%> (-0.28%) ⬇️
routers/home.go 45.45% <0%> (-0.85%) ⬇️
modules/avatar/avatar.go 81.25% <0%> (-18.75%) ⬇️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c101a...7c96bf7. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2019
@lunny lunny merged commit c812ba7 into go-gitea:master Feb 28, 2019
@lunny lunny deleted the lunny/change_password branch February 28, 2019 08:02
lunny added a commit to lunny/gitea that referenced this pull request Feb 28, 2019
* fix display dashboard even if require to change password

* fix comments
@lunny lunny added the backport/done All backports for this PR have been created label Feb 28, 2019
lunny added a commit that referenced this pull request Feb 28, 2019
* fix display dashboard even if require to change password

* fix comments
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants