Skip to content

Conversation

jolheiser
Copy link
Member

Fixes #6056

Issues were being loaded raw instead of with attributes. Changed the API to use the func that loads attributes.

issue api milestone

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 19, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 19, 2019
@codecov-io
Copy link

Codecov Report

Merging #6122 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6122      +/-   ##
==========================================
- Coverage   38.85%   38.84%   -0.02%     
==========================================
  Files         352      352              
  Lines       50030    50030              
==========================================
- Hits        19440    19434       -6     
- Misses      27776    27783       +7     
+ Partials     2814     2813       -1
Impacted Files Coverage Δ
routers/api/v1/repo/issue.go 23.46% <0%> (ø) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 44.54% <0%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 987a521...add7dd6. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 19, 2019
@lafriks lafriks merged commit ba0749b into go-gitea:master Feb 19, 2019
@sankethpb
Copy link

sankethpb commented Feb 25, 2019

@lafriks Is there any workaround for this in 1.7.2?
Would be great to have it back ported to 1.7.3, thank you.

@lafriks
Copy link
Member

lafriks commented Feb 25, 2019

Please backport to 1.7

@jolheiser jolheiser deleted the 6056_api_issue_milestone branch February 26, 2019 01:32
jolheiser added a commit to jolheiser/gitea that referenced this pull request Feb 26, 2019
Signed-off-by: jolheiser <john.olheiser@gmail.com>
techknowlogick pushed a commit that referenced this pull request Feb 26, 2019
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api request for issue always returns nil for milestone
7 participants