Skip to content

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Feb 19, 2019

Fix #4339

user with simple bio:
user with simple bio
user with no bio:
user with no bio
user with xss attempt that was escaped:
user with xss attempt that was escaped

@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Feb 19, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Feb 19, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 19, 2019
@codecov-io
Copy link

codecov-io commented Feb 19, 2019

Codecov Report

Merging #6113 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6113      +/-   ##
==========================================
- Coverage   38.88%   38.87%   -0.02%     
==========================================
  Files         364      365       +1     
  Lines       51215    51341     +126     
==========================================
+ Hits        19916    19959      +43     
- Misses      28432    28509      +77     
- Partials     2867     2873       +6
Impacted Files Coverage Δ
models/user.go 49.76% <ø> (ø) ⬆️
modules/auth/user_form.go 42.85% <ø> (ø) ⬆️
routers/user/setting/profile.go 40.81% <100%> (+0.4%) ⬆️
models/webhook.go 63.18% <0%> (-5.54%) ⬇️
modules/context/api.go 50.61% <0%> (-0.21%) ⬇️
models/repo.go 47.36% <0%> (-0.09%) ⬇️
routers/repo/webhook.go 1.73% <0%> (-0.05%) ⬇️
routers/admin/hooks.go 0% <0%> (ø)
routers/routes/routes.go 83.44% <0%> (+0.36%) ⬆️
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba2f6a4...d2368b0. Read the comment docs.

@zeripath
Copy link
Contributor

I think LDAP also has a user description attribute - although I'm not sure how many installs use it.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 19, 2019
@techknowlogick techknowlogick merged commit d1c982c into go-gitea:master Mar 19, 2019
@techknowlogick techknowlogick deleted the add-user-bio branch March 19, 2019 02:28
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] User biography
6 participants