Skip to content

Upgrade go-sql-driver/mysql to fix invalid connection error #5748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

Upgrade go-sql-driver/mysql to fix invalid connection error #5748

merged 1 commit into from
Jan 17, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 17, 2019

should fix #5736

@lunny lunny added the type/bug label Jan 17, 2019
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 17, 2019
@codecov-io
Copy link

Codecov Report

Merging #5748 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5748   +/-   ##
=======================================
  Coverage   37.73%   37.73%           
=======================================
  Files         325      325           
  Lines       47760    47760           
=======================================
  Hits        18024    18024           
  Misses      27140    27140           
  Partials     2596     2596

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac6da3...84af207. Read the comment docs.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 17, 2019
@zeripath zeripath merged commit 477a80f into go-gitea:master Jan 17, 2019
@lunny lunny deleted the lunny/upgrade_mysql_driver branch January 17, 2019 06:57
@lafriks lafriks added this to the 1.8.0 milestone Jan 21, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Random 500 error Invalid connection
6 participants
@lunny @codecov-io @techknowlogick @zeripath @lafriks @bkcsoft