Skip to content

fix code review on mssql #5502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 11, 2018
Merged

fix code review on mssql #5502

merged 4 commits into from
Dec 11, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 9, 2018 •
edited by techknowlogick
Loading

will fix #5458

@lunny lunny added the type/bug label Dec 9, 2018
@lunny lunny mentioned this pull request Dec 9, 2018
Closed
7 tasks
@codecov-io
Copy link

codecov-io commented Dec 9, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@1b3404e). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5502   +/-   ##
=========================================
  Coverage          ?   37.62%           
=========================================
  Files             ?      317           
  Lines             ?    46835           
  Branches          ?        0           
=========================================
  Hits              ?    17624           
  Misses            ?    26708           
  Partials          ?     2503
Impacted Files Coverage Δ
models/review.go 64.07% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b3404e...fec3d9d. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 9, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 9, 2018
@chdxD1
Copy link
Contributor

chdxD1 commented Dec 10, 2018 •
edited
Loading

Hi,
thanks for looking into this!
I have tested and verified that PRs are now working on MSSQL (despite not being the nicest code 🙈 Thanks Microsoft for implementing plain relational logic...)

@lunny
Copy link
Member Author

lunny commented Dec 10, 2018

@chdxD1 Yes, this is a quick fix. And we can refactor that later.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 10, 2018
@lunny lunny added this to the 1.7.0 milestone Dec 10, 2018
@Cellebyte
Copy link

@lunny, @chdxD1 tested it this morning and pull requests are working again.

@lunny lunny merged commit 284b0e1 into go-gitea:master Dec 11, 2018
@lunny lunny deleted the lunny/fix_mssql_review branch December 11, 2018 01:27
@lunny
Copy link
Member Author

lunny commented Dec 11, 2018

This bug is for review summary, no need to back port to v1.6

@lunny lunny mentioned this pull request Dec 11, 2018
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

[mssql] Pull Request Database Issue
7 participants
@lunny @codecov-io @chdxD1 @Cellebyte @lafriks @sapk @bkcsoft