Skip to content

Fix windows build broken by #416 #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2017
Merged

Fix windows build broken by #416 #543

merged 1 commit into from
Jan 1, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 31, 2016

No description provided.

@lunny lunny added the type/bug label Dec 31, 2016
@lunny lunny added this to the 1.1.0 milestone Dec 31, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Dec 31, 2016

I am not a huge fan of doing this... is there not another lib we can use?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 31, 2016
@lunny
Copy link
Member Author

lunny commented Dec 31, 2016

Maybe endless? But I only used this one.

@appleboy
Copy link
Member

appleboy commented Dec 31, 2016 •
edited
Loading

@bkcsoft endless doesn't also support windows platform now. I do the same way in my gorush application.

for unix: https://github.com/appleboy/gorush/blob/v1.7.2/gorush/server_unix.go
for windows: https://github.com/appleboy/gorush/blob/v1.7.2/gorush/server_windows.go

LGTM 👍

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 31, 2016
@andreynering
Copy link
Contributor

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 1, 2017
@andreynering andreynering merged commit aea1b2b into go-gitea:master Jan 1, 2017
@lunny lunny deleted the lunny/fallback_graceful_windows branch January 1, 2017 13:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @bkcsoft @appleboy @andreynering @tboerger