Don't write to log NoCommitterAccount #3621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's way too verbose, and the information is also printed to the user already. Fixes #3602.
Codecov Report
@@ Coverage Diff @@
## master #3621 +/- ##
==========================================
- Coverage 36.15% 36.14% -0.01%
==========================================
Files 285 285
Lines 40921 40924 +3
==========================================
Hits 14794 14794
- Misses 23953 23957 +4
+ Partials 2174 2173 -1
Continue to review full report at Codecov.
|
Bwko
approved these changes
Mar 3, 2018
|
@thehowl You should determine if the |
|
Done. |
|
@thehowl there is a function could do that. see https://github.com/thehowl/gitea/blob/f42e2d4771b8d158a7dbb8ec5ab34ffa4e7e1893/models/error.go#L84 |
|
Refresh the change set ;). I remembered immediately after I committed |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's way too verbose, and the information is also printed to the user
already. Fixes #3602.