Skip to content

Fix package link setting can only list limited repositories #35394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Fix package link setting can only list limited repositories #35394

wants to merge 10 commits into from
+86 −81

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 1, 2025 •
edited
Loading

Fix #24801

image

@lunny lunny added type/bug backport/v1.24 This PR should be backported to Gitea 1.24 labels Sep 1, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 1, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/frontend labels Sep 1, 2025
@lunny lunny removed the backport/v1.24 This PR should be backported to Gitea 1.24 label Sep 1, 2025
@lunny lunny added this to the 1.25.0 milestone Sep 1, 2025
silverwind
silverwind reviewed Sep 4, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 8, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 9, 2025
wxiaoguang
wxiaoguang reviewed Sep 9, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Sep 9, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Sep 9, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Sep 9, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Sep 9, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Sep 9, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Sep 9, 2025
View reviewed changes
@wxiaoguang wxiaoguang marked this pull request as draft September 9, 2025 06:31
wxiaoguang
wxiaoguang reviewed Sep 9, 2025
View reviewed changes
web_src/js/features/package-setting.ts
Comment on lines +3 to +6
export function initPackageSettings() {
if (!document.querySelector('.page-content.package.settings')) return;
initCompSearchRepoBox();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use our "global event/init" framework. Just like I have shown you in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@silverwind silverwind silverwind approved these changes

+1 more reviewer

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation topic/packages type/bug
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

Unable to select all available repositories when linking package to repository
6 participants
@lunny @silverwind @wxiaoguang @hiifong @techknowlogick @GiteaBot