Skip to content

Use github.com/mholt/archives replace github.com/mholt/archiver #35390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 1, 2025
Merged

Use github.com/mholt/archives replace github.com/mholt/archiver #35390

merged 14 commits into from
Sep 1, 2025

Conversation

junoberryferry
Copy link
Contributor

@junoberryferry junoberryferry commented Aug 31, 2025 •
edited by lunny
Loading

Fix #32620

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 31, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/dependencies labels Aug 31, 2025
@lunny lunny changed the title Use mholt/archives and fix https://github.com/go-gitea/gitea/issues/35387 Use github.com/mholt/archives replace github.com/mholt/archiver Aug 31, 2025
lunny
lunny reviewed Aug 31, 2025
View reviewed changes
@lunny lunny added this to the 1.25.0 milestone Aug 31, 2025
wxiaoguang
wxiaoguang reviewed Aug 31, 2025
View reviewed changes
@wxiaoguang
Update modules/dump/dumper_test.go
6257543 
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang
Copy link
Contributor

It needs to use ArchiveAsync, otherwise IterateObjects will generate a huge file list for a large instance.

wxiaoguang
wxiaoguang reviewed Aug 31, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 1, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 1, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 1, 2025
@lunny lunny enabled auto-merge (squash) September 1, 2025 18:50
@lunny lunny merged commit ec75bdb into go-gitea:main Sep 1, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 1, 2025
hiifong added a commit to hiifong/gitea that referenced this pull request Sep 2, 2025
@hiifong
Merge branch 'main' into squash-merge-msg
1f14255 
* main:
  [skip ci] Updated translations via Crowdin
  Use github.com/mholt/archives replace github.com/mholt/archiver (go-gitea#35390)
  Move some functions from package git to gitrepo (go-gitea#33910)
  Move git config/remote to gitrepo package and add global lock to resolve possible conflict when updating repository git config file (go-gitea#35151)
  Move HasWiki to repository service package (go-gitea#33912)
  Rename UpdateBranch API to RenameBranch API (go-gitea#35374)
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 2, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
fb54d91 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Use github.com/mholt/archives replace github.com/mholt/archiver (go-gitea#35390)
  Move some functions from package git to gitrepo (go-gitea#33910)
  Move git config/remote to gitrepo package and add global lock to resolve possible conflict when updating repository git config file (go-gitea#35151)
  Move HasWiki to repository service package (go-gitea#33912)
  Rename UpdateBranch API to RenameBranch API (go-gitea#35374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/dependencies modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

github.com/mholt/archiver package is deprecated
4 participants
@junoberryferry @wxiaoguang @lunny @GiteaBot