Skip to content

split admin config settings templates to make it maintain easier #35294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2025
Merged

split admin config settings templates to make it maintain easier #35294

merged 2 commits into from
Sep 4, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 16, 2025

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 16, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 16, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Aug 16, 2025
@lunny lunny force-pushed the lunny/admin_setting_templates_split branch from e84fd27 to 15c40a6 Compare August 22, 2025 03:04
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 22, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 4, 2025
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 4, 2025
@denyskon denyskon enabled auto-merge (squash) September 4, 2025 15:14
@denyskon denyskon merged commit 3e3c36b into go-gitea:main Sep 4, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Sep 4, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 4, 2025
@lunny lunny modified the milestones: 1.26.0, 1.25.0 Sep 4, 2025
@lunny lunny deleted the lunny/admin_setting_templates_split branch September 4, 2025 16:53
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 5, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ecd783c 
* giteaofficial/main:
  Refactor and update mail templates (go-gitea#35150)
  Disable Field count validation of CSV viewer (go-gitea#35228)
  split admin config settings templates to make it maintain easier (go-gitea#35294)
  Update tools/package.json dependencies, remove imagemin-zopfli (go-gitea#35406)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denyskon denyskon denyskon approved these changes

+1 more reviewer

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @denyskon @hiifong @GiteaBot