Skip to content

Conversation

TimB87
Copy link
Contributor

@TimB87 TimB87 commented Aug 13, 2025

Hi all,

this is an attempt to fix #35230 as discussed in the ticket.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 13, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Aug 13, 2025
@ChristopherHX
Copy link
Contributor

ChristopherHX commented Aug 13, 2025

I would suggest to run make fmt and make fix to fix the compliance check

edit GitHub linked it already, nevermind

@TimB87
Copy link
Contributor Author

TimB87 commented Aug 13, 2025

I am not really familiar with go, I ran go-fmt -w earlier and it pulled together 1*time.Hour.

Running make fmt and make fix changes nothing and gives no feedback either. Not sure what I am missing.

@ChristopherHX
Copy link
Contributor

Actually nothing was missing, just a rate limited download in the CI. Rerun resolved this.

Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This token should indeed be valid for the whole job livetime, if the job terminates earlier more expensive checks will prevent usage after task completion

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 13, 2025
@ChristopherHX ChristopherHX added the backport/v1.24 This PR should be backported to Gitea 1.24 label Aug 13, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 14, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 14, 2025
@lunny lunny added the type/bug label Aug 14, 2025
@lunny lunny enabled auto-merge (squash) August 14, 2025 06:31
@lunny lunny merged commit 4ff8cdf into go-gitea:main Aug 14, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Aug 14, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 14, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Aug 14, 2025
This is an attempt to fix go-gitea#35230 as discussed in the ticket.
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Aug 14, 2025
lunny pushed a commit that referenced this pull request Aug 14, 2025
Backport #35271 by @TimB87

This is an attempt to fix #35230 as discussed in the ticket.

Co-authored-by: Tim Biermann <tbier@posteo.de>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 19, 2025
* giteaofficial/main:
  Refactor smal code snippeds in models/issues/pull.go  (go-gitea#35301)
  fix: remove duplicate IDs (go-gitea#35210)
  Add start time on perf trace because it seems some steps haven't been recorded. (go-gitea#35282)
  nix dev shell add zip (go-gitea#35300)
  [skip ci] Updated translations via Crowdin
  Fix LFS range size header response (go-gitea#35277)
  Skip "parentsigned" check when the repo is empty (go-gitea#35292)
  [skip ci] Updated translations via Crowdin
  Fix GitHub release assets URL validation (go-gitea#35287)
  nix flake use go1.25 (go-gitea#35288)
  go1.25.0 (go-gitea#35262)
  fix nix dev shell on darwin (go-gitea#35278)
  Fix token lifetime, closes go-gitea#35230 (go-gitea#35271)
  OneDev migration: fix broken migration caused by various REST API changes in OneDev 7.8.0 and later (go-gitea#35216)
  [skip ci] Updated translations via Crowdin
  Fix font-size in inline code comment preview (go-gitea#35209)
  Fix a bug where lfs gc never worked. (go-gitea#35198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can token lifetime for actions be a configurable thing?
4 participants