Skip to content

Fix the bug when the last code comment deleted, a review comment type comment is still in the activity list of the pull request #35133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix the bug when the last code comment deleted, a review comment type comment is still in the activity list of the pull request #35133

wants to merge 7 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 20, 2025 •
edited
Loading

Fix #29715

  • Ensure that a review comment with no content is also deleted when its last associated code comment is removed.

  • Introduced API functionality for deleting code comments.

@lunny
Fix the bug when the last code comment deleted, a review comment type…
98f0ab2 
… comment is still in the activity list of the pull request
@lunny lunny added the type/bug label Jul 20, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 20, 2025
@lunny lunny marked this pull request as draft July 20, 2025 19:32
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/frontend labels Jul 20, 2025
@lunny lunny mentioned this pull request Jul 20, 2025
Open
@lunny lunny marked this pull request as ready for review August 1, 2025 18:30
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/api This PR adds API routes or modifies them modifies/frontend modifies/go Pull requests that update Go code type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When deleting code review comment, the activity log will not be deleted
3 participants
@lunny @lafriks @GiteaBot