Skip to content

Fix some missed GitHeadRefName when renaming #35102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2025
Merged

Fix some missed GitHeadRefName when renaming #35102

merged 2 commits into from
Jul 17, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 16, 2025

some changes missed from #35093

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 16, 2025
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Jul 16, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jul 16, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 17, 2025
wxiaoguang
wxiaoguang approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We indeed need strict typed variables in templates

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 17, 2025
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 17, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) July 17, 2025 14:00
@wxiaoguang wxiaoguang merged commit 8ee9603 into go-gitea:main Jul 17, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jul 17, 2025
@lunny lunny deleted the lunny/fix_missed_GitRefName branch July 17, 2025 16:30
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 18, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
3ddb542 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Increase gap on latest commit (go-gitea#35104)
  Fix job status aggregation logic (go-gitea#35000)
  Fix some missed GitHeadRefName when renaming (go-gitea#35102)
  Fix error logs and improve some comments/messages (go-gitea#35105)
  Support Basic Authentication for archive downloads (go-gitea#35087)
  Run `uv run` with `--frozen` (go-gitea#35097)
  Improve package API log handling (go-gitea#35100)
  Rename pull request GetGitRefName to GetGitHeadRefName (go-gitea#35093)
  Fix review comment/dimiss comment x reference can be refereced back (go-gitea#35094)
  Fix submodule nil check (go-gitea#35096)
  Redirect to a presigned URL of HEAD for HEAD requests (go-gitea#35088)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @wxiaoguang @delvh @GiteaBot