Skip to content

Refactor "change file" API #34855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 25, 2025
Merged

Refactor "change file" API #34855

merged 5 commits into from
Jun 25, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jun 25, 2025 •
edited
Loading

Follow up the "editor" refactor, use the same approach to simplify code, and fix some docs & comments

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 25, 2025
@wxiaoguang wxiaoguang marked this pull request as draft June 25, 2025 04:23
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jun 25, 2025
@wxiaoguang wxiaoguang force-pushed the fix-various branch 2 times, most recently from cb0f35d to 3ad218d Compare June 25, 2025 05:25
@wxiaoguang wxiaoguang changed the title Fix some trivial problems Refactor "change file" API Jun 25, 2025
@wxiaoguang wxiaoguang marked this pull request as ready for review June 25, 2025 05:32
@wxiaoguang wxiaoguang force-pushed the fix-various branch 2 times, most recently from 28a0ac3 to d6c5c6c Compare June 25, 2025 05:47
@wxiaoguang wxiaoguang mentioned this pull request Jun 25, 2025
Closed
delvh
delvh reviewed Jun 25, 2025
View reviewed changes
wxiaoguang and others added 3 commits June 25, 2025 15:34
@wxiaoguang @delvh
Update modules/structs/repo_file.go
a6e4b61 
Co-authored-by: delvh <dev.lh@web.de>
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang
fix typo
6a56389
@wxiaoguang
fix test
3721358
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 25, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 25, 2025
@lunny lunny added this to the 1.25.0 milestone Jun 25, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 25, 2025
@lunny lunny merged commit 75aa23a into go-gitea:main Jun 25, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 25, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 26, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
e0ab522 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Add issue delete notifier (go-gitea#34592)
  Refactor "change file" API (go-gitea#34855)
  Fix some log and UI problems (go-gitea#34863)
  Update go tool dependencies (go-gitea#34845)
  Fix archive API (go-gitea#34853)
  Update `uint8-to-base64`, remove type stub (go-gitea#34844)
  Refactor repo contents API and add "contents-ext" API (go-gitea#34822)
  [skip ci] Updated translations via Crowdin
  fix(issue): Replace stopwatch toggle with explicit start/stop actions (go-gitea#34818)
  Remove unused variable HUGO_VERSION (go-gitea#34840)
  Fix SSH LFS timeout (go-gitea#34838)
  Ignore force pushes for changed files in a PR review (go-gitea#34837)
  Fix log fmt (go-gitea#34810)
  Fix team permissions (go-gitea#34827)
  Fix job status aggregation logic (go-gitea#34823)
  [skip ci] Updated translations via Crowdin
  correct migration tab name (go-gitea#34826)
  Refactor template helper (go-gitea#34819)
@wxiaoguang wxiaoguang deleted the fix-various branch June 26, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @delvh @GiteaBot