Skip to content

Refactor repo contents API and add "contents-ext" API #34822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 25, 2025
Merged

Refactor repo contents API and add "contents-ext" API #34822

merged 4 commits into from
Jun 25, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jun 23, 2025 •
edited
Loading

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 23, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jun 23, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jun 23, 2025
Closed
@wxiaoguang wxiaoguang force-pushed the fix-contents-api branch 3 times, most recently from 6fd2c3a to aa52636 Compare June 23, 2025 13:00
@wxiaoguang wxiaoguang mentioned this pull request Jun 23, 2025
Closed
@rickyma
Copy link
Contributor

rickyma commented Jun 23, 2025 •
edited
Loading

Could we add a field to indicate whether a file is stored in LFS? e.g. storedInLFS?
I find out it is hard for us to distinguish whether a file is stored in LFS or not.
I have to parse the LFS pointer file myself... I don't know if gitea supports this currently?

My company is now choosing to use Gitea in our case. So there are many issues we've been faced with.

@wxiaoguang wxiaoguang force-pushed the fix-contents-api branch 2 times, most recently from 76b95b9 to d21b93b Compare June 23, 2025 15:47
@wxiaoguang wxiaoguang added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jun 23, 2025
@wxiaoguang wxiaoguang added this to the 1.25.0 milestone Jun 23, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 23, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 25, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jun 25, 2025 •
edited
Loading

Since this is a new design with an API, also cc @go-gitea/maintainers , if there is any problem, let's fix/improve/revert.

@wxiaoguang wxiaoguang enabled auto-merge (squash) June 25, 2025 02:09
@wxiaoguang wxiaoguang merged commit dbd9c69 into go-gitea:main Jun 25, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-contents-api branch June 25, 2025 02:52
@rickyma

This comment was marked as off-topic.

Sign in to view
@wxiaoguang

This comment was marked as off-topic.

Sign in to view
@go-gitea go-gitea locked and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.25.0
5 participants
@wxiaoguang @rickyma @lunny @hiifong @GiteaBot