Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 11, 2017

As title.

@lunny lunny added the type/bug label Dec 11, 2017
@lunny lunny added this to the 1.4.0 milestone Dec 11, 2017
@lafriks
Copy link
Member

lafriks commented Dec 11, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 11, 2017
@sapk
Copy link
Member

sapk commented Dec 11, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2017
@codecov-io
Copy link

Codecov Report

Merging #3153 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3153      +/-   ##
==========================================
+ Coverage   34.74%   34.74%   +<.01%     
==========================================
  Files         276      276              
  Lines       39945    39945              
==========================================
+ Hits        13877    13880       +3     
+ Misses      24074    24071       -3     
  Partials     1994     1994
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/issue.go 45.02% <0%> (+0.2%) ⬆️
models/error.go 33.63% <0%> (+0.61%) ⬆️
models/issue_indexer.go 67.53% <0%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b82519c...abf1fae. Read the comment docs.

@lunny lunny merged commit 3b525d5 into go-gitea:master Dec 11, 2017
@lunny lunny deleted the lunny/fix_gpg_tmpl branch December 11, 2017 14:08
@lunny
Copy link
Member Author

lunny commented Dec 11, 2017

fixed #3151

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants