Skip to content

Conversation

sillyguodong
Copy link
Contributor

@sillyguodong sillyguodong commented May 19, 2023

close #24540

related:

changes:

  • Add column of labels to table action_runner, and combine the value of agent_labels and custom_labels column to labels column.
  • Store labels when registering act_runner.
  • Update labels when act_runner starting and calling Declare.
  • Users cannot modify the custom labels in edit page any more.

other changes:

  • Store version when registering act_runner.
  • If runner is latest version, parse version from Declare. But older version runner still parse version from request header.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 19, 2023
@sillyguodong sillyguodong added the topic/gitea-actions related to the actions of Gitea label May 19, 2023
@wolfogre wolfogre self-requested a review June 5, 2023 10:42
@sillyguodong sillyguodong marked this pull request as ready for review June 6, 2023 03:46
@sillyguodong sillyguodong changed the title [WIP] Support changing labels of Actions runner without re-registration Support changing labels of Actions runner without re-registration Jun 6, 2023
Copy link
Member

@wolfogre wolfogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 9, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 13, 2023
@lunny lunny added this to the 1.21.0 milestone Jun 13, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 13, 2023
@lunny lunny merged commit 8228751 into go-gitea:main Jun 13, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 13, 2023
lunny pushed a commit that referenced this pull request Jun 14, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 15, 2023
* upstream/main: (31 commits)
  Show OAuth2 errors to end users (go-gitea#25261)
  [skip ci] Updated translations via Crowdin
  Fix index generation parallelly failure (go-gitea#25235)
  Fix variable in template (go-gitea#25267)
  Add template linting via djlint (go-gitea#25212)
  Fix edit OAuth application width (go-gitea#25262)
  Use flex to align SVG and text (go-gitea#25163)
  GitHub Actions enhancements for frontend (go-gitea#25150)
  Add missing `v` in migrations.go (go-gitea#25252)
  Change form actions to fetch for submit review box (go-gitea#25219)
  Fix panic when migrating a repo from GitHub with issues (go-gitea#25246)
  Fix description of drop custom_labels migration (go-gitea#25243)
  Fix all possible setting error related storages and added some tests (go-gitea#23911)
  [skip ci] Updated translations via Crowdin
  Revert overflow: overlay (revert go-gitea#21850) (go-gitea#25231)
  Support changing labels of Actions runner without re-registration (go-gitea#24806)
  Improve AJAX link and modal confirm dialog (go-gitea#25210)
  Use inline SVG for built-in OAuth providers (go-gitea#25171)
  Disable `Create column` button while the column name is empty  (go-gitea#25192)
  Fix profile render when the README.md size is larger than 1024 bytes (go-gitea#25131)
  ...
@ExplodingDragon
Copy link
Contributor

Will this patch be backported to 1.20?

@lunny
Copy link
Member

lunny commented Jun 15, 2023

Will this patch be backported to 1.20?

It will not

NexZhu pushed a commit to daotl/gitea_act_runner that referenced this pull request Jun 20, 2023
Implement proposal: go-gitea/gitea#24540

Related:
- Protocol: https://gitea.com/gitea/actions-proto-def/pulls/9
- Gitea side: go-gitea/gitea#24806

Co-authored-by: Jason Song <i@wolfogre.com>
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/201
Reviewed-by: Jason Song <i@wolfogre.com>
Co-authored-by: sillyguodong <gedong_1994@163.com>
Co-committed-by: sillyguodong <gedong_1994@163.com>
lunny pushed a commit that referenced this pull request Aug 4, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 11, 2023
@denyskon denyskon added the type/enhancement An improvement of existing functionality label Nov 13, 2023
@sillyguodong sillyguodong deleted the feature/declare_labels branch February 29, 2024 03:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/gitea-actions related to the actions of Gitea type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Support changing labels of Actions runner without re-registration
7 participants