Skip to content

Conversation

Zettat123
Copy link
Contributor

The isAdmin param is no longer used so the comment should be removed.

// The isAdmin param should be set to true when rendering the Admin page.
func RenderRepoSearch(ctx *context.Context, opts *RepoSearchOptions) {

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 27, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2023
@delvh delvh added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Feb 27, 2023
@yardenshoham yardenshoham added this to the 1.20.0 milestone Feb 27, 2023
@yardenshoham yardenshoham added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Feb 27, 2023
@KN4CK3R KN4CK3R merged commit 6117058 into go-gitea:main Feb 27, 2023
@KN4CK3R KN4CK3R removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 27, 2023
@yardenshoham yardenshoham added the backport/done All backports for this PR have been created label Feb 27, 2023
yardenshoham pushed a commit to yardenshoham/gitea that referenced this pull request Feb 27, 2023
lunny pushed a commit that referenced this pull request Feb 27, 2023
Backport #23173

The `isAdmin` param is no longer used so the comment should be removed.

https://github.com/go-gitea/gitea/blob/d27d36f2f4dd389050e613967ad2a5d02d250acc/routers/web/explore/repo.go#L36-L37

Co-authored-by: Zettat123 <zettat123@gmail.com>
@Zettat123 Zettat123 deleted the remove-comment branch February 28, 2023 01:21
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 28, 2023
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Change button text for commenting and closing an issue at the same time (go-gitea#23135)
  Don't run unnecessary steps when only docs changed (go-gitea#23103)
  Add word-break to sidebar-item-link (go-gitea#23146)
  Speed up HasUserStopwatch & GetActiveStopwatch (go-gitea#23051)
  Add InsecureSkipVerify to Minio Client for Storage (go-gitea#23166)
  Fix Fomantic UI's `touchstart` fastclick, always use `click` for click events (go-gitea#23065)
  Remove useless comment in go-gitea#23114 (go-gitea#23173)
  Remove xin-u from maintainers (go-gitea#23170)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants