Skip to content

Conversation

yardenshoham
Copy link
Member

Backport #23030

This PR is a possible solution for issue #22866. Main change is to add a author-wrapper class around author name, like the wrapper added to message. The max-width is set to 200px on PC, and 100px on mobile device for now. Which will work like below:

截屏2023-02-21 11 57 53

截屏2023-02-21 11 58 43

And title is added to the wrapper like it did in message wrapper. So the full author name will show on hover.

This PR is a possible solution for issue go-gitea#22866. Main change is to add a
`author-wrapper` class around author name, like the wrapper added to
message. The `max-width` is set to 200px on PC, and 100px on mobile
device for now.
@yardenshoham yardenshoham added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 23, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 23, 2023
@jolheiser jolheiser added this to the 1.19.0 milestone Feb 23, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 24, 2023
@lunny lunny merged commit ddf6137 into go-gitea:release/v1.19 Feb 24, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 24, 2023
@yardenshoham yardenshoham deleted the backport-23030-v1.19 branch February 24, 2023 08:59
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants