Skip to content

Fix code view (diff) broken layout (#23096) #23918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2023
Merged

Fix code view (diff) broken layout (#23096) #23918

merged 2 commits into from
Apr 4, 2023

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Apr 4, 2023

Backport #23096 by @wxiaoguang

Close #22911

I think it's ready for review now, feel free to test it, welcome to help to improve.

Before

image

After

image

@GiteaBot GiteaBot added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 4, 2023
@GiteaBot GiteaBot added this to the 1.19.1 milestone Apr 4, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 4, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 4, 2023 •
edited
Loading

Actually , some values like <col width="50"> and <col width="10"> are not fine-tuned. I just put the number there when I was writing the demo .... the main PR got merged faster than I thought.

Do we need some more time to do fine-tune then backport?

ps: if most people think these numbers are fine, that's also good 😁

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 4, 2023
@6543
Copy link
Member

6543 commented Apr 4, 2023

Actually , some values like <col width="50"> and <col width="10"> are not fine-tuned. I just put the number there when I was writing the demo .... the main PR got merged faster than I thought.

Do we need some more time to do fine-tune then backport?

ps: if most people think these numbers are fine, that's also good grin

I think it's good as backport to fix it ... fine tuning it for main could be done later

@6543 6543 merged commit 7c180ff into go-gitea:release/v1.19 Apr 4, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
@techknowlogick techknowlogick deleted the backport-23096-v1.19 branch September 9, 2023 05:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

+1 more reviewer

@yardenshoham yardenshoham yardenshoham approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.19.1
Development

Successfully merging this pull request may close these issues.
6 participants
@GiteaBot @wxiaoguang @6543 @silverwind @yardenshoham @lunny