Skip to content

Clarify Gitea/Crowdin locale behaviors, add tests for LocaleStore, fix some strings with semicolons #23819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2023
Merged

Clarify Gitea/Crowdin locale behaviors, add tests for LocaleStore, fix some strings with semicolons #23819

merged 3 commits into from
Mar 31, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 30, 2023 •
edited
Loading

Follow #23633 and #23240

Close #23814

Now we almost have a complete test set for Gitea's LocalStore.

This PR is still a quick fix for the legacy locale system (see the TODOs), to resolve the problems fundamentally, it needs more work in the future.

@wxiaoguang wxiaoguang mentioned this pull request Mar 30, 2023
Closed
@wxiaoguang wxiaoguang force-pushed the improve-locales branch 5 times, most recently from 6499f43 to af0cc36 Compare March 30, 2023 11:22
@wxiaoguang wxiaoguang changed the title Clarify Gitea/Crowdin locale behaviors, improve LocaleStore and update-locales.sh Clarify Gitea/Crowdin locale behaviors, add tests for LocaleStore, fix some strings with semicolons Mar 30, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 30, 2023
@lunny lunny added this to the 1.20.0 milestone Mar 30, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 31, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 31, 2023
@lunny lunny merged commit 288c2e8 into go-gitea:main Mar 31, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 31, 2023
@wxiaoguang wxiaoguang deleted the improve-locales branch March 31, 2023 04:18
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 31, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
9ada9c1 
* giteaoffical/main:
  Fix 500 error if there is a name conflict when edit authentication source (go-gitea#23832)
  Use different SVG for pending and running actions (go-gitea#23836)
  CSS color tweaks (go-gitea#23828)
  Clarify Gitea/Crowdin locale behaviors, add tests for LocaleStore, fix some strings with semicolons (go-gitea#23819)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Semicolons in locale_en-US.ini
4 participants
@wxiaoguang @lunny @wolfogre @GiteaBot