Improve workflow event triggers #23613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wrong fixing issue? |
This PR is to fix a bug mentioned in #22958 (comment). I've updated the description. |
lunny
approved these changes
Mar 22, 2023
wolfogre
reviewed
Mar 23, 2023
I've added some unit tests in the latest commit, please review again |
wolfogre
approved these changes
Mar 23, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 23, 2023
Follow go-gitea#23037 Fix [go-gitea#22598 comment](go-gitea#22958 (comment)) Workflows with `pull_request` trigger event can't be triggered by `pull_request_sync` event. This PR adds the `canGithubEventMatch` function to check if a Github event can match any Gitea event. If the Github event matches a Gitea event, the related workflows should be triggered. --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
lunny
pushed a commit
that referenced
this pull request
Mar 23, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 24, 2023
* upstream/main: Fix incorrect `HookEventType` of pull request review comments (go-gitea#23650) [skip ci] Updated translations via Crowdin Fix codeblocks in the cheat sheet (go-gitea#23664) Drop migration for ForeignReference (go-gitea#23605) Fix new issue/pull request btn margin when it is next to sort (go-gitea#23647) A tool to help to backport locales, changes source strings to fix other broken translations (go-gitea#23633) Fix incorrect `show-modal` and `show-panel` class (go-gitea#23660) Restructure documentation. Now the documentation has installation, administration, usage, development, contributing the 5 main parts (go-gitea#23629) Check LFS/Packages settings in dump and doctor command (go-gitea#23631) Use a general approach to show tooltip, fix temporary tooltip bug (go-gitea#23574) Improve workflow event triggers (go-gitea#23613) Improve `<SvgIcon>` to make it output `svg` node and optimize performance (go-gitea#23570)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #23037
Fix #22598 comment
Workflows with
pull_requesttrigger event can't be triggered bypull_request_syncevent. This PR adds thecanGithubEventMatchfunction to check if a Github event can match any Gitea event. If the Github event matches a Gitea event, the related workflows should be triggered.