Skip to content

Replace a few fontawesome icons with svg #23602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2023
Merged

Replace a few fontawesome icons with svg #23602

merged 2 commits into from
Mar 21, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 20, 2023 •
edited
Loading

Replaced a few icons with SVG. The only ones left are some in actions (idk why new code introduces legacy icons) and a few dropdown icons.

Screenshot 2023-03-21 at 00 52 36

Screenshot 2023-03-21 at 00 47 03

Screenshot 2023-03-21 at 00 33 47

@silverwind silverwind added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 20, 2023
@silverwind silverwind added this to the 1.20.0 milestone Mar 20, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 21, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 21, 2023
@6543 6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 21, 2023
@delvh
Copy link
Member

delvh commented Mar 21, 2023

So, once the remaining icons have been replaced, there's even a JS dependency we can drop?

@jolheiser jolheiser enabled auto-merge (squash) March 21, 2023 01:08
@jolheiser jolheiser disabled auto-merge March 21, 2023 01:09
@jolheiser jolheiser enabled auto-merge (squash) March 21, 2023 01:09
@jolheiser
Copy link
Member

🎺 🤖

@jolheiser jolheiser merged commit 34a2cf5 into go-gitea:main Mar 21, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 21, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
d4f3fc7 
* upstream/main:
  Replace a few fontawesome icons with svg (go-gitea#23602)
  Fix pagination on `/notifications/watching` (go-gitea#23564)
  Fix `.locale.Tr` function not found in delete modal (go-gitea#23468)
  fix submodule is nil panic (go-gitea#23588)
  `Publish Review` buttons should indicate why they are disabled (go-gitea#23598)
  Improve template error reporting (go-gitea#23396)
  Polyfill the window.customElements (go-gitea#23592)
  Add CHANGELOG for 1.19.0 (go-gitea#23583)
@silverwind
Copy link
Member Author

So, once the remaining icons have been replaced, there's even a JS dependency we can drop?

Don't see any. What can be dropped is the font-awesome/css/font-awesome.css CSS import and potentially the fomantic icon module, but that one is CSS only.

@silverwind silverwind deleted the svgicons branch March 21, 2023 15:06
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 21, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@jolheiser jolheiser jolheiser approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @delvh @jolheiser @6543 @GiteaBot