Skip to content

Fix some broken css (#23560) #23567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2023
Merged

Fix some broken css (#23560) #23567

merged 2 commits into from
Mar 19, 2023

Conversation

GiteaBot
Copy link
Collaborator

Backport #23560 by @wxiaoguang

  1. The "close" inside "modal" are likely broken for long time
    • There is no var called --body-color
    • There is no fullscreen modal
    • The .ui.modal > .close.inside doesn't seem to match most icons. It only matches a few like "fork-repo-modal" or "adopt repo". Other places are just buggy code copied again and again.
  2. Convert the legacy &:hover LESS syntax to CSS syntax

@wxiaoguang @GiteaBot
Fix some broken css (go-gitea#23560)
7764617 
1. The "close" inside "modal" are likely broken for long time
    * There is no var called `--body-color`
    * There is no `fullscreen modal`
* The `.ui.modal > .close.inside` doesn't seem to match most icons. It
only matches a few like "fork-repo-modal" or "adopt repo". Other places
are just buggy code copied again and again.
2. Convert the legacy `&:hover` LESS syntax to CSS syntax
@GiteaBot GiteaBot added this to the 1.19.0 milestone Mar 18, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 18, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 18, 2023
@delvh delvh added topic/ui Change the appearance of the Gitea UI type/bug reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 18, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) March 19, 2023 01:37
@techknowlogick
Copy link
Member

ping lg-tm

@techknowlogick techknowlogick merged commit 3f253b3 into go-gitea:release/v1.19 Mar 19, 2023
@techknowlogick techknowlogick deleted the backport-23560-v1.19 branch March 19, 2023 01:37
@techknowlogick techknowlogick removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 19, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GiteaBot @techknowlogick @jolheiser @delvh @wxiaoguang